Skip to content

chore(rstack): add SVG logo variants - #91

Draft
SoonIter wants to merge 5 commits into
rstackjs:mainfrom
SoonIter:codex/add-rstack-logo-variants
Draft

chore(rstack): add SVG logo variants#91
SoonIter wants to merge 5 commits into
rstackjs:mainfrom
SoonIter:codex/add-rstack-logo-variants

Conversation

@SoonIter

@SoonIter SoonIter commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

image

Validation

  • reviewed all 24 icons against the Figma design
  • validated every SVG with xmllint
  • verified that the SVGs contain no external Figma references, embedded images, or raster assets

Checklist

Not applicable: this PR only adds SVG assets and no PNG files.

Copilot AI lite review requested due to automatic review settings August 26, 2026 11:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc64145a4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rstack/logos/outline/rsdoctor.svg Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new, structured set of Rstack-family SVG logo variants under rstack/logos/ (5 styles × 8 products), and documents the stable CDN paths for consumers of these assets.

Changes:

  • Added 40 new SVG logo assets across avatar, outline, outline-fill, website, and simplified variants.
  • Documented the new rstack/logos structure and CDN usage examples.
  • Linked the new logo variants from the repository root README.

Reviewed changes

Copilot reviewed 2 out of 42 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Link to the new Rstack logo variants and rstack/ directory.
rstack/logos/README.md Document logo variant directories and stable CDN paths.
rstack/logos/avatar/rsbuild.svg Add avatar-style SVG for Rsbuild.
rstack/logos/avatar/rsdoctor.svg Add avatar-style SVG for Rsdoctor.
rstack/logos/avatar/rslib.svg Add avatar-style SVG for Rslib.
rstack/logos/avatar/rslim.svg Add avatar-style SVG for Rslim.
rstack/logos/avatar/rslint.svg Add avatar-style SVG for Rslint.
rstack/logos/avatar/rspack.svg Add avatar-style SVG for Rspack.
rstack/logos/avatar/rspress.svg Add avatar-style SVG for Rspress.
rstack/logos/avatar/rstest.svg Add avatar-style SVG for Rstest.
rstack/logos/outline/rsbuild.svg Add outline-style SVG for Rsbuild.
rstack/logos/outline/rsdoctor.svg Add outline-style SVG for Rsdoctor.
rstack/logos/outline/rslib.svg Add outline-style SVG for Rslib.
rstack/logos/outline/rslim.svg Add outline-style SVG for Rslim.
rstack/logos/outline/rslint.svg Add outline-style SVG for Rslint.
rstack/logos/outline/rspack.svg Add outline-style SVG for Rspack.
rstack/logos/outline/rspress.svg Add outline-style SVG for Rspress.
rstack/logos/outline/rstest.svg Add outline-style SVG for Rstest.
rstack/logos/outline-fill/rsbuild.svg Add outline-fill style SVG for Rsbuild.
rstack/logos/outline-fill/rsdoctor.svg Add outline-fill style SVG for Rsdoctor.
rstack/logos/outline-fill/rslib.svg Add outline-fill style SVG for Rslib.
rstack/logos/outline-fill/rslim.svg Add outline-fill style SVG for Rslim.
rstack/logos/outline-fill/rslint.svg Add outline-fill style SVG for Rslint.
rstack/logos/outline-fill/rspack.svg Add outline-fill style SVG for Rspack.
rstack/logos/outline-fill/rspress.svg Add outline-fill style SVG for Rspress.
rstack/logos/outline-fill/rstest.svg Add outline-fill style SVG for Rstest.
rstack/logos/simplified/rsbuild.svg Add simplified style SVG for Rsbuild.
rstack/logos/simplified/rsdoctor.svg Add simplified style SVG for Rsdoctor.
rstack/logos/simplified/rslib.svg Add simplified style SVG for Rslib.
rstack/logos/simplified/rslim.svg Add simplified style SVG for Rslim.
rstack/logos/simplified/rslint.svg Add simplified style SVG for Rslint.
rstack/logos/simplified/rspack.svg Add simplified style SVG for Rspack.
rstack/logos/simplified/rspress.svg Add simplified style SVG for Rspress.
rstack/logos/simplified/rstest.svg Add simplified style SVG for Rstest.
rstack/logos/website/rsbuild.svg Add website-style SVG for Rsbuild.
rstack/logos/website/rsdoctor.svg Add website-style SVG for Rsdoctor.
rstack/logos/website/rslib.svg Add website-style SVG for Rslib.
rstack/logos/website/rslim.svg Add website-style SVG for Rslim.
rstack/logos/website/rslint.svg Add website-style SVG for Rslint.
rstack/logos/website/rspack.svg Add website-style SVG for Rspack.
rstack/logos/website/rspress.svg Add website-style SVG for Rspress.
rstack/logos/website/rstest.svg Add website-style SVG for Rstest.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SoonIter
SoonIter force-pushed the codex/add-rstack-logo-variants branch from dc64145 to 95bd569 Compare August 26, 2026 11:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95bd569d60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rstack/logos/avatar/rsbuild.svg Outdated
@SoonIter
SoonIter force-pushed the codex/add-rstack-logo-variants branch 3 times, most recently from 1ab94f1 to 1ab2d69 Compare August 27, 2026 08:07
@SoonIter
SoonIter force-pushed the codex/add-rstack-logo-variants branch from 1ab2d69 to 0953441 Compare August 27, 2026 08:13
@SoonIter

Copy link
Copy Markdown
Member Author

SVG post-export cleanup

After exporting the artwork from Figma, I applied the following cleanup to each SVG:

  • Kept the files standalone: retained the root xmlns and viewBox, and omitted fixed root width/height values so consumers can size the icons.
  • Preserved rendering semantics: kept all path geometry, fills, strokes, opacity, gradients, clip paths, transforms, overflow behavior, and the nested preserveAspectRatio values required to reproduce the Figma placement.
  • Preserved the intended variants: avatar and website assets retain their category-specific backgrounds, while simplified assets use a transparent background.
  • Removed Figma-only layer information: deleted 2,091 unreferenced layer id attributes. This reduced the SVG set by 30,573 bytes without changing path data.
  • Kept and namespaced functional definitions: retained the 65 IDs referenced by gradients or clip paths, renamed them with variant/product prefixes, and updated every reference. All IDs are globally unique, so multiple icons can be safely inlined in one document.
  • Excluded non-standalone content: verified that the files contain no external Figma URLs, data:image payloads, raster <image> elements, scripts, style blocks, titles, descriptions, or metadata nodes.
  • Avoided risky optimization: did not reduce path precision, merge paths, flatten transforms, or remove structural groups when doing so could change the artwork.

Validation performed:

  • all 24 SVGs pass xmllint;
  • all 65 functional references resolve to definitions;
  • no duplicate functional IDs remain across files;
  • 256×256 rasterized renders before and after the metadata/ID cleanup are byte-identical.

@SoonIter

Copy link
Copy Markdown
Member Author
image

@SoonIter

Copy link
Copy Markdown
Member Author

after optimization

image

@SoonIter
SoonIter marked this pull request as draft August 27, 2026 11:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0922e7555

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 96 96"><g fill="none" transform="matrix(.6843 0 0 .68422 24.7 5.2)"><path fill="url(#a)" d="M7.6 63.3A29 29 0 0 0 10.7 99c.9.8-2.4 3.2-1.1 5.5.7 1.8 2.9 2.8 3.9 3.4 15.8 8.2 39.8 2.7 48.6-11.5s1.4-34-12.8-43a30.3 30.3 0 0 0-41.7 9.8"/><path fill="#4e342e" fill-rule="evenodd" d="M31.3 50.6a2 2 0 0 1 0-1.5q-3.5 0-6.8 1.2l-.7.1q-4 1.4-7 3.4A29 29 0 0 0 3.2 83.7q1 6.9 5.2 12.7l1 1a25 25 0 0 1 7.3-3.4l.1-.2q.6.3 1.6 0l6.3-2.6.5-.3q.7-.3 1-1t0-1.8l-.7-3.4-.2-1.2v-.9q-.2-2.6.4-5l.3-1 .7-1.1-.6-.8h1.3l.2-.1q1.8-1.5 4-2.3L39 69q.7-.5 1-1.4l.7-3.1 1.1-3.3q.9.1 1.2.7t.3 1.3q.3 2.3-.2 3.8c-1.6 5.1-7.4 6.3-11.5 8.4-1.2.6-2.6 1.5-3.2 2.7q-1.1 2.4-.4 5.2l1 3.4q1.3 5.1-3.3 7.4c-2.4 1.2-4.6 1.8-7.5 2.7a21 21 0 0 0-6.8 3c-1.3 1-2.6 2.8-2 4.5q.4 1.2 1.7 2.2c2.7 2 6.3 3.2 9.4 4q3.6 1 7.3 1.2 7.2.3 14-1.5a36 36 0 0 0 17.9-10.6c6-7 7.5-16.3 5-25a35 35 0 0 0-13.6-19.9L48.4 53l1 .2 6.3 2.2 1.6.6A40 40 0 0 1 69 83.3q-.2 9.5-6 17a44 44 0 0 1-51.5 10c-3.5-2-6.6-5-4.7-9.4l.6-1v-.2a31 31 0 0 1-7-14.8A33.6 33.6 0 0 1 29.9 46l1.8.7q-.3 1.9-.3 3.8" clip-rule="evenodd"/><path fill="#ff8a65" d="M50 53.9A31 31 0 0 0 7.3 63a30 30 0 0 0 2.2 34.1 30 30 0 0 1 1.6-27.5 31 31 0 0 1 42.6-9.2q5.4 3.5 9 8.3a32 32 0 0 0-12.7-15"/><path fill="#424242" fill-rule="evenodd" d="m57.3 56-1.6-.7-6.2-2.2-1-.2-1-.5a.1.1 0 0 0-.2 0l-.1.1-1.1 2.2q-.9 1-2 1a.1.1 0 0 0-.2.1l-.2.7-.5 1.6-.3 1.5q-.2.7-1 1.6l-.1.5-.2.4-.8 2.4-.7 3q-.3 1-1 1.5-1 .8-2.3 1.2l.2-.8v-.1h-.1q-2.3.2-4.4 0-2.3-.4-4.6.2-.6.2-.9.9l-1.3 4.2h.5l.6.9q-1 0-2 .5l-.6.6v.2l.1.1h.1q1 0 1.7-.3l-.3 1-1.1.1-.5.5-1.3 4.5h2.4l.1.8c-1 0-3.7 0-4 1.3l.1.2q2-.5 4-.3 0 .5.3.8-1.8 0-3.3.2-.8 0-1.2.7l-1.4 4.3h.1l5.3.2-.5.3-.8.4h-.4c-1.4 0-4.4-.4-5 1.2v.2h.2l2.6-.3-3 1q-.7.5-1.5 0 0-1.5 1.1-3l.1-.1 1.7-5q0-1.2.6-2.1l.6-1 2.8-7.8.1-.2 1.6-4.8v-.2q0-1.6 1-2.7l.3-.5 3-8.1.5-1.8 1.7-4.8v-.2l-.7-.8.3-3.8-1.8-.7-11.9-4.3c-1-.3-1.2-.9-1.8-1.9q-2.7-4.5-4-7.6-.3-.5 0-1.3l8.1-23.9q.7-1.5 2.5-2.3 4-2.3 8.7-4.6.6-.4 1.3 0l21 7.1 23.7 8.5c.9.3 1.5 1.4 1.9 2.2q2 4.6 3.4 8.8.3 1-.2 2.2-4 11.8-8.7 24-.3.9-1.1 1.2a48 48 0 0 1-8.9 3.5q-1.2.3-2.4-.4zM21.8 8 14 31q-.4 1 .4 2.1l3.8 6.4v-.1a9 9 0 0 1 .7-2.7q.1-.4.6-.2a10 10 0 0 1-.4 3.4q0 .3.3.5l43.4 15.2v-.1q.5-1.3 1.4-2.5l.2-.2a.2.2 0 0 1 .3.2 5 5 0 0 1-.8 2.6v.1h.3q3.9-1.4 7.2-3 .7-.2 1-.8l8.3-23.4q.4-.7.2-1.5l-3.6-8.8-.1.2a38 38 0 0 1-2.7 5.8l-.2-.1V23a33 33 0 0 1 2.3-5.5l-.3-.3-11-3.9q-.7-.3-1.1.2l-3.3 3.1q-.4.4-1 .2l-14.7-5.2q-.9-.2-1-.8l-.6-5L32.9 2a.1.1 0 0 0-.2 0v.1q-1 3.2-3 6h-.5a20 20 0 0 1 2.6-6h-.4L24 6q-1.6.5-2.2 2m38.3 7.6h.2l2.8-2.8v-.3L45.3 6.3a.2.2 0 0 0-.3.2l.4 3.8v.2zM39.2 52.9l4.5 1q.6.4.8-.2l.9-2.2-.2-.2-5-1.7-6.5-2.4-.3.2-.5 2.4.2.5q3 1.6 6.1 2.6m2.8 2.4-.1-.1q-2-.5-3.8-1.2l-4.6-1.7-2 5.7v.2h7.3q1.2 0 2.1-.3l.4-.3zm-6.2 3.8q-2.6-.2-5 .3l-.6.5v.3a.2.2 0 0 0 .2.3q2.6-.5 5.3-.2t5-.4l.5-.5.1-.3a.2.2 0 0 0-.2-.3q-2.6.6-5.3.3m-7.3 7.3a.1.1 0 0 0 .2 0q1.8-.2 3.9 0h2.7l2.9-.5.3-.6 1.3-4.2-3.6.1q-3.1-.5-5.7.2l-.4.4-.3.8zm4.4.8q-2.6-.1-5 .5l-.6.5-.1.3a.2.2 0 0 0 .3.3q2.6-.6 5.3-.3 2.7.1 5-.5l.6-.5.1-.3a.2.2 0 0 0-.3-.3q-2.6.6-5.3.3" clip-rule="evenodd"/><path fill="#9e9e9e" fill-rule="evenodd" d="m29.2 8.1-1.1.7q0-.3-.3-.3L23 8.1q-.3 0-.4.2l-.8-.2q.6-1.5 2.3-2l7.7-4v.2Q30 5 29.2 8.1m-9.6 28.5.5.3h.8l1.5.8q4.2 1.8 8.3 2.6l4.9 2.3q7 2.6 14.3 5 .5.2.8 0L54 49q4.6 1.8 8.7 3 1.5.8 2.3.3v.3h.2q.4.2.7.1a31 31 0 0 0 5.6-.8v-.2q-.2-.4-.8-.3-2.9 0-5.6.7v-.8q.7-.2 1-1 4.6-12.5 8.1-22.7.2-.6-.2-1 .3-.4.3-1c0-.7-.6-1.7-1.5-1.4q-.3-.4-.7-.5a210 210 0 0 0-17.7-6L49.3 16q-9-4-18.3-7-.4 0-.7.2l-.7-1.1h-.1l.2-.2a21 21 0 0 0 3.1-6h.1l10.7 3.8.2.3.4 4.8q.1.6 1 .8l14.7 5.2q.6.1 1-.2l3.3-3.1q.4-.5 1-.2l11.4 4.2v.1q-1.4 2.6-2.3 5.4v1l.2.2h.1l.2-.2a38 38 0 0 0 2.6-5.8l3.5 8.8q.2.8-.2 1.5L72.3 52q-.2.6-.9.9L64 55.8v-.2q.7-1.2.8-2.5a.2.2 0 0 0-.3-.2l-.2.2a9 9 0 0 0-1.4 2.6h-.3L19.4 40.6q-.4-.2-.3-.5.5-1.6.5-3.4m60.2-8-.2-.7-4.1-2.6-.7.1.2.7 4.1 2.6z" clip-rule="evenodd"/><path fill="#9e9e9e" fill-rule="evenodd" d="m60 15.7-14.5-5.2-.1-.2-.4-3.8.2-.2 17.9 6.3v.3l-2.8 2.7z" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="M22.6 8.3q.2.7 1 .7 1.5.3 3.1.3 1 .1 1.4-.5l1.1-.7h.4l.7 1.2q0 .6.8 1 8.6 3.5 18.2 5.8l5 1.7 10.5 4.5 7 2.3c.3.1.9.1 1-.3.9-.3 1.4.7 1.5 1.4q0 .6-.3 1-.5.3-.7.9Q69 38.8 65 50.2v2.2q-1 .4-2.4-.2.2-.3 0-.5v-.1L62 51l-11.3-3.6-.8.1-16-5.8-3.2-1.5a64 64 0 0 0-8.7-3.5l-1 .1h-1l-.4-.3-.5-.5v-.3l-.1-.5a18 18 0 0 0-3.7-4h-.5L14 31l7.8-23zm.7 14.2L19.5 34q-.3 1 .1 1.2.4 0 .8-.9a558 558 0 0 0 7.8-22.7q.3-1 0-1.2-.5-.1-.8 1-2.2 5.5-4 11.2M49 27l4.9-6.6q0-.6-.5-.8l-8.1-.8q-.5-.1-.7.4L38 29c-.3.5-.6 1 .2 1.3l5.7 1.8-4.8 7.5q-.4.5.1.8.3.2.6 0L56.4 30q.6-.4.3-1l-.3-.1z" clip-rule="evenodd"/><path fill="#424242" fill-rule="evenodd" d="M28 8.8q-.4.6-1.3.5L23.6 9q-.8 0-1-.7l.4-.2 4.8.4q.3 0 .3.3m21.2 7.3q-9.6-2.3-18.2-5.9-.7-.3-.8-1h.7a157 157 0 0 1 18.3 7m-21.2-5.9q.4.1.1 1.2a558 558 0 0 1-7.8 22.7q-.4 1-.8.9-.4-.2 0-1.2a558 558 0 0 1 7.8-22.7q.3-1 .7-.9m44.7 14c-.1.4-.7.4-1 .3L61.3 21l-7-3.2a210 210 0 0 1 18.5 6.5M48.9 27l7.5 1.8.3.2q.3.5-.3.9L40 40.5l-.6-.1q-.5-.3-.1-.8L44 32l-5.6-1.7c-.8-.2-.5-.8-.2-1.3l6.4-9.8q.3-.4.7-.4l8.1.8q.6.2.5.8l-.4.6zm-7 10.8 12.7-8.1v-.1l-7-1.7h-.1q-.5-.2-.3-.8l4.8-6.3v-.1l-6.6-.6h-.2l-5.8 9.2L45 31q1 .5.2 1.4z" clip-rule="evenodd"/><path fill="#ffca28" fill-rule="evenodd" d="m41.8 37.8 3.4-5.4q.8-1-.2-1.4l-5.6-1.7 5.8-9.1.2-.1 6.6.6-4.8 6.4q-.2.6.3.8l7 1.7h.1z" clip-rule="evenodd"/><path fill="#424242" fill-rule="evenodd" d="m79.8 28.5-.7.2L75 26l-.2-.6.7-.2 4.1 2.6zM74 26.7q.5.4.2 1l-8.1 22.7q-.3.8-1 1v-1.2q4-11.4 8.2-22.6.2-.6.7-1" clip-rule="evenodd"/><path fill="#9e9e9e" fill-rule="evenodd" d="m14.8 31.3.1.5q1.6 2.2 3.7 3.9h.4l.1.4.4.5q-.4-.2-.6.2a9 9 0 0 0-.7 2.8H18l-.4-.5-3.2-5.9q-.7-1-.4-2.1z" clip-rule="evenodd"/><path fill="#424242" fill-rule="evenodd" d="m19 35.8-.4-.1a18 18 0 0 1-3.7-4v-.4h.4a18 18 0 0 1 3.7 4q.3.3 0 .5m11.7 4.5A45 45 0 0 1 21 37q.6-.3 1 0 4.5 1.3 8.8 3.4" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="m40.3 49.6-1 3.3a36 36 0 0 1-6.4-2.8v-.3l.5-2.4.3-.2z" clip-rule="evenodd"/><path fill="#424242" fill-rule="evenodd" d="M62.7 52.2a109 109 0 0 1-12-4.7l.1-.2L62 51.1l.7.5h.1z" clip-rule="evenodd"/><path fill="#9e9e9e" fill-rule="evenodd" d="m39.2 52.9 1-3.3 5 1.7a.3.3 0 0 1 .2.4l-1 2q-.1.5-.7.3z" clip-rule="evenodd"/><path fill="#424242" fill-rule="evenodd" d="M65 52.4v-.2q3-.6 5.7-.7.6 0 .8.3l-.2.3a31 31 0 0 1-6.1.6H65z" clip-rule="evenodd"/><path fill="#8d6e63" fill-rule="evenodd" d="M42 55.3v.5l-.9 2-.2.1q-.9.3-2.1.3h-7.2l-.1-.1V58l2-5.7.2-.1 4.4 1.8q1.8.7 3.8 1.2z" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="M35.8 59q2.6.4 5.3-.2a.2.2 0 0 1 .2.3l-.1.3-.5.5q-2.4.6-5 .4-2.6-.3-5.3.3a.2.2 0 0 1-.3-.4l.1-.3.6-.5q2.4-.5 5-.3" clip-rule="evenodd"/><path fill="#8d6e63" fill-rule="evenodd" d="M28.5 66.4V66l1.8-4.4.2-.2c1.8-.6 3.5-.4 5.7-.2q1.7.1 3.6-.1a.1.1 0 0 1 .2.2l-1.8 4.6-.3.1q-1.8.4-2.5.4h-2.8a15 15 0 0 0-4 0" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="M32.9 67.2q2.7.3 5.3-.3a.2.2 0 0 1 .3.2v.4l-.6.5q-2.4.6-5 .5-2.9-.3-5.4.3a.2.2 0 0 1-.3-.3l.1-.3.5-.5q2.5-.6 5-.5" clip-rule="evenodd"/><path fill="#8d6e63" fill-rule="evenodd" d="M36.8 70.2q-2.4 1.2-5 2-2.3.9-4.1 2.4h-2.1v-.1l1.4-4.1q.3-.7.9-.9 2.2-.6 4.6-.2 2.2.2 4.4 0l.1.1z" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="m26.8 75.5-.7 1.1-1.9.1.6-.7q1-.6 2-.5" clip-rule="evenodd"/><path fill="#8d6e63" fill-rule="evenodd" d="M25.8 77.5q-.5 2.5-.5 5.1l-2.4.1-.2-.2 1.5-4.3.5-.5z" clip-rule="evenodd"/><path fill="#fafafa" fill-rule="evenodd" d="M50.4 83.4q1 2-.5 3.8-1 1.2-2.6 1.8-2.4.9-4.7-.2c-2.3-1.3-1.8-3.9 0-5.4q1.4-1.2 3.2-1.5c1.7-.3 3.6 0 4.6 1.5" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="m25.4 83.5.2 1.2a14 14 0 0 0-4.2.3v-.2c.3-1.4 3-1.3 4-1.3" clip-rule="evenodd"/><path fill="#8d6e63" fill-rule="evenodd" d="m25.8 85.5.6 2.6q.1 1-.1 1.8-.3.7-1 1l-5.3-.1a.2.2 0 0 1-.2-.3l1.5-4q.4-.8 1.2-.8 1.5-.3 3.3-.2" clip-rule="evenodd"/><path fill="#fafafa" fill-rule="evenodd" d="M52.6 91.5a4 4 0 0 1 1.6 4.6 10 10 0 0 1-4.6 5.4 13 13 0 0 1-9 2q-3.2-.6-4.2-3.4-.3-1.6.5-3.3c1.9-3.9 6.3-6.1 10.5-6.5q2.8-.3 5.2 1.2" clip-rule="evenodd"/><path fill="#bdbdbd" fill-rule="evenodd" d="M24.8 91.2q-1.6.9-3.4 1.5l-2.8.3v-.2c.6-1.6 3.6-1.2 5-1.1h.4z" clip-rule="evenodd"/><defs><linearGradient id="a" x1="58.8" x2="7.6" y1="102" y2="63.3" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#ffe57f"/><stop offset=".5" stop-color="#ffab91"/><stop offset=".7" stop-color="#ffab91"/></linearGradient></defs></g></svg> No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Namespace the simplified SVG definition IDs

When multiple simplified logos are inlined in one HTML document, their document-global IDs collide, so references such as url(#a) can resolve to another logo's gradient or filter and render incorrectly. Fresh evidence after the reported 0953441 fix is that the reviewed tree's optimized simplified files again share id="a" across all seven logos and id="b" across Rslint, Rspack, and Rstest; preserve product-specific IDs during optimization.

Useful? React with 👍 / 👎.

Comment thread rstack/logos/README.md
- [`simplified`](./simplified): simplified product marks

Each directory contains icons for Rspack, Rsbuild, Rslib, Rspress, Rsdoctor,
Rstest, Rslint, and Rslim.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the nonexistent Rslim listing

The reviewed commit contains no rslim.svg in any of the three directories—or anywhere else in its tree—despite this sentence promising an Rslim icon in each directory. Because repository paths are deployed verbatim, readers following this inventory will construct asset URLs that return no file; either add the three advertised assets or remove Rslim from the list.

AGENTS.md reference: AGENTS.md:L11-L13

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants